fix: reinstall missing plugin folders with enableAfterInstall honored
When a managed plugin's folder was empty/missing at update time, BRAT reinstalled it via updatePlugin(), which hard-codes enableAfterInstall=false, so the plugin came back on disk but stayed disabled until toggled by hand. Detect absence with adapter.exists() (the errno check was desktop-only) and pass the user's enableAfterInstall setting to the fresh install.
This commit is contained in:
1 parent
f69790c2f9
commit
a6b42a1aa7
3 files changed
+13
-15
No files matched your search
+1
-1
@@ -1,7 +1,7 @@
|
||||
{
|
||||
"id": "obsidian42-brat-gitea",
|
||||
"name": "BRAT (Gitea Fork)",
|
||||
"version": "1.0.1",
|
||||
"version": "1.0.2",
|
||||
"minAppVersion": "1.11.4",
|
||||
"description": "Easily install beta plugins from GitHub AND self-hosted Gitea/Forgejo instances.",
|
||||
"author": "TfTHacker (Gitea fork)",
|
||||
|
||||
+1
-1
@@ -1,6 +1,6 @@
|
||||
{
|
||||
"name": "obsidian42-brat-gitea",
|
||||
"version": "1.0.1",
|
||||
"version": "1.0.2",
|
||||
"description": "BRAT fork with Gitea support — install beta plugins from GitHub or self-hosted Gitea/Forgejo.",
|
||||
"main": "main.js",
|
||||
"scripts": {
|
||||
|
||||
+11
-13
@@ -579,28 +579,26 @@ export default class BetaPlugins {
|
||||
} else {
|
||||
// Update existing plugin
|
||||
const pluginTargetFolderPath = `${this.plugin.app.vault.configDir}/plugins/${primaryManifest.id}/`;
|
||||
let localManifestContents = "";
|
||||
try {
|
||||
localManifestContents = await this.plugin.app.vault.adapter.read(
|
||||
`${pluginTargetFolderPath}manifest.json`,
|
||||
);
|
||||
} catch (e) {
|
||||
const err = e as { errno?: number };
|
||||
if (err.errno === -4058 || err.errno === -2) {
|
||||
await this.addPlugin(
|
||||
const localManifestPath = `${pluginTargetFolderPath}manifest.json`;
|
||||
const vaultAdapter = this.plugin.app.vault.adapter;
|
||||
if (!(await vaultAdapter.exists(localManifestPath))) {
|
||||
// Plugin folder is empty/missing (deleted by sync, by hand, ...).
|
||||
// Reinstall it. updatePlugin() hard-codes enableAfterInstall=false
|
||||
// for plain updates, which here would leave the plugin installed
|
||||
// but disabled, so use the user's setting instead.
|
||||
return await this.addPlugin(
|
||||
repositoryPath,
|
||||
false,
|
||||
usingBetaManifest,
|
||||
false,
|
||||
specifyVersion,
|
||||
false,
|
||||
enableAfterInstall,
|
||||
this.plugin.settings.enableAfterInstall,
|
||||
secretName,
|
||||
);
|
||||
return true;
|
||||
}
|
||||
console.log("BRAT - Local Manifest Load", primaryManifest.id, e);
|
||||
}
|
||||
const localManifestContents =
|
||||
await vaultAdapter.read(localManifestPath);
|
||||
|
||||
if (specifyVersion !== "" && specifyVersion !== "latest") {
|
||||
toastMessage(
|
||||
|
||||
Reference in new issue
Block a user